Add bell support for eat terminal #2125
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archigup
force-pushed
the
archigup-patch-1
branch
2 times, most recently
from
9af0851 to
7ff53f8
Compare
Member
Author
|
Failed checks seem unrelated |
The emacs eat terminal (crates/cli/src/cli/chat/util/mod.rs) handles beeps fine, and the beep feature only works for allowlisted terminals.
archigup
force-pushed
the
archigup-patch-1
branch
from
7ff53f8 to
d2fd5a0
Compare
Member
Author
|
Moved this to aws/amazon-q-developer-cli-autocomplete#357 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The emacs eat terminal handles beeps fine, and the beep feature only works for allowlisted terminals.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.